You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Peace Software (JIRA)" <ad...@incubator.apache.org> on 2006/12/21 01:09:21 UTC

[jira] Created: (ADFFACES-337) Have to click save twice when in field with ppr trigger

Have to click save twice when in field with ppr trigger
-------------------------------------------------------

                 Key: ADFFACES-337
                 URL: http://issues.apache.org/jira/browse/ADFFACES-337
             Project: MyFaces ADF-Faces
          Issue Type: Bug
            Reporter: Peace Software


We have a problem where if you type into a field which will trigger a ppr and then click the save button with the mouse you have to do so twice for the submit to go through.  This is also occurrs if you type into the field and press ALT-S, our hotkey for save.

I have tried setting the firstClickPassed=true on the body tag but this is not working. Stepping through the javascript, _pprConsumeBlockedEvent,  I can see this is because it does not recognise our save and cancel buttons as submit elements as they are command inks.  Can you please extend this function to recognise links?

I have also noticed that the code is using the explicitOriginalTarget to get the target of the event, rather than the originalTarget which means when we use the hotkey to save the code is checking to see if the field typed in is a submit element rather than the link, also if we happen to click on the text of the link the originalTarget is a Text element.  I'm not sure why the code is using the explicitOriginalTarget but using just the originalTarget would solve a lot of issues for us.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ADFFACES-337) Have to click save twice when in field with ppr trigger

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-337:
----------------------------------------

    Affects Version/s: 1.0.1-incubating-core-SNAPSHOT

> Have to click save twice when in field with ppr trigger
> -------------------------------------------------------
>
>                 Key: ADFFACES-337
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-337
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>    Affects Versions: 1.0.1-incubating-core-SNAPSHOT
>            Reporter: Peace Software
>
> We have a problem where if you type into a field which will trigger a ppr and then click the save button with the mouse you have to do so twice for the submit to go through.  This is also occurrs if you type into the field and press ALT-S, our hotkey for save.
> I have tried setting the firstClickPassed=true on the body tag but this is not working. Stepping through the javascript, _pprConsumeBlockedEvent,  I can see this is because it does not recognise our save and cancel buttons as submit elements as they are command inks.  Can you please extend this function to recognise links?
> I have also noticed that the code is using the explicitOriginalTarget to get the target of the event, rather than the originalTarget which means when we use the hotkey to save the code is checking to see if the field typed in is a submit element rather than the link, also if we happen to click on the text of the link the originalTarget is a Text element.  I'm not sure why the code is using the explicitOriginalTarget but using just the originalTarget would solve a lot of issues for us.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ADFFACES-337) Have to click save twice when in field with ppr trigger

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/ADFFACES-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462337 ] 

Adam Winer commented on ADFFACES-337:
-------------------------------------

Can you provide a JSP or Facelets testcase and instructions on how to reproduce?

> Have to click save twice when in field with ppr trigger
> -------------------------------------------------------
>
>                 Key: ADFFACES-337
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-337
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>            Reporter: Peace Software
>
> We have a problem where if you type into a field which will trigger a ppr and then click the save button with the mouse you have to do so twice for the submit to go through.  This is also occurrs if you type into the field and press ALT-S, our hotkey for save.
> I have tried setting the firstClickPassed=true on the body tag but this is not working. Stepping through the javascript, _pprConsumeBlockedEvent,  I can see this is because it does not recognise our save and cancel buttons as submit elements as they are command inks.  Can you please extend this function to recognise links?
> I have also noticed that the code is using the explicitOriginalTarget to get the target of the event, rather than the originalTarget which means when we use the hotkey to save the code is checking to see if the field typed in is a submit element rather than the link, also if we happen to click on the text of the link the originalTarget is a Text element.  I'm not sure why the code is using the explicitOriginalTarget but using just the originalTarget would solve a lot of issues for us.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (ADFFACES-337) Have to click save twice when in field with ppr trigger

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/ADFFACES-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465345 ] 

Adam Winer commented on ADFFACES-337:
-------------------------------------

Here's a testcase:

<jsp:root xmlns:jsp="http://java.sun.com/JSP/Page" version="2.0"
          xmlns:f="http://java.sun.com/jsf/core"
          xmlns:tr="http://myfaces.apache.org/trinidad" >
  <jsp:directive.page contentType="text/html;charset=utf-8"/>
  <f:view>
 <tr:document title="InputText Demo">
        <tr:form>     
          <tr:panelGroupLayout layout="vertical">
            <tr:inputText autoSubmit="true" label="Label" value="Some text"/>
            <tr:commandLink text="Submit"/>
            <tr:commandButton text="Submit"/>
          </tr:panelGroupLayout>
        </tr:form>
 </tr:document>
  </f:view>
</jsp:root>

Started looking at this, but it's nasty code.

> Have to click save twice when in field with ppr trigger
> -------------------------------------------------------
>
>                 Key: ADFFACES-337
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-337
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>            Reporter: Peace Software
>
> We have a problem where if you type into a field which will trigger a ppr and then click the save button with the mouse you have to do so twice for the submit to go through.  This is also occurrs if you type into the field and press ALT-S, our hotkey for save.
> I have tried setting the firstClickPassed=true on the body tag but this is not working. Stepping through the javascript, _pprConsumeBlockedEvent,  I can see this is because it does not recognise our save and cancel buttons as submit elements as they are command inks.  Can you please extend this function to recognise links?
> I have also noticed that the code is using the explicitOriginalTarget to get the target of the event, rather than the originalTarget which means when we use the hotkey to save the code is checking to see if the field typed in is a submit element rather than the link, also if we happen to click on the text of the link the originalTarget is a Text element.  I'm not sure why the code is using the explicitOriginalTarget but using just the originalTarget would solve a lot of issues for us.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira