[jira] [Commented] (REEF-610) Make NetworkConnectionService be able to register multiple identifiers

["Brian Cho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706392#comment-14706392 ] 

Brian Cho commented on REEF-610:
--------------------------------

The PR is currently in the process of review. I'd like to ask if anyone has objections to removing methods here, instead of painfully deprecating? I don't think anyone is using NetworkConnectionService in place of NetworkService yet.

If we go that route, we should probably also retroactively add {{@Unstable}} to this part of the code.

> Make NetworkConnectionService be able to register multiple identifiers
> ----------------------------------------------------------------------
>
>                 Key: REEF-610
>                 URL: https://issues.apache.org/jira/browse/REEF-610
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF-IO
>            Reporter: Geon Woo Kim
>            Assignee: Geon Woo Kim
>
> There is a case where a service is injected in a context and registers context identifier through NetworkConnectionService, simultaneously another service registers task identifier through NCS. In that case, multiple IDs are registered in NameServer through NetworkConnectionService without any unregistering and NetworkConnectionService maintains the last registered ID. All network messages from the NCS have sourceId as the last registered ID, it might be a wrong behavior. We need to change NCS to gracefully register/unregister multiple identifiers.
> 1. Deprecate registerId/unregisterId method of NCS and [Unbind|Bind]NetworkConnectionServiceFromTask
> 2. Make each NetworkConnectionFactory has own end point identifier (It is different from connectionFactoryId that is used to distinguish the type of connection)
> 3. The end point id for a NetworkConnectionFactory is registered when the NCF is registered to NetworkConnectionService.
> 4. The registered end point id is unregistered when the NetworkConnectionFactory is removed from NCS.
> 5. All registered end point ids are unregistered when NCS is closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)