You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/09/25 14:24:37 UTC
svn commit: r1893622 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java
Author: tilman
Date: Sat Sep 25 14:24:37 2021
New Revision: 1893622
URL: http://svn.apache.org/viewvc?rev=1893622&view=rev
Log:
PDFBOX-4892: optimize memory usage, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java?rev=1893622&r1=1893621&r2=1893622&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInputStream.java Sat Sep 25 14:24:37 2021
@@ -23,6 +23,7 @@ import java.io.FilterInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
@@ -66,23 +67,25 @@ public final class COSInputStream extend
static COSInputStream create(List<Filter> filters, COSDictionary parameters, InputStream in,
DecodeOptions options) throws IOException
{
- List<DecodeResult> results = new ArrayList<>();
+ if (filters.isEmpty())
+ {
+ return new COSInputStream(in, Collections.<DecodeResult>emptyList());
+ }
+
+ List<DecodeResult> results = new ArrayList<>(filters.size());
InputStream input = in;
- if (!filters.isEmpty())
+ Set<Filter> filterSet = new HashSet<>(filters);
+ if (filterSet.size() != filters.size())
+ {
+ throw new IOException("Duplicate");
+ }
+ ByteArrayOutputStream output = new ByteArrayOutputStream();
+ // apply filters
+ for (int i = 0; i < filters.size(); i++)
{
- Set<Filter> filterSet = new HashSet<>(filters);
- if (filterSet.size() != filters.size())
- {
- throw new IOException("Duplicate");
- }
- ByteArrayOutputStream output = new ByteArrayOutputStream();
- // apply filters
- for (int i = 0; i < filters.size(); i++)
- {
- output.reset();
- results.add(filters.get(i).decode(input, output, parameters, i, options));
- input = new ByteArrayInputStream(output.toByteArray());
- }
+ output.reset();
+ results.add(filters.get(i).decode(input, output, parameters, i, options));
+ input = new ByteArrayInputStream(output.toByteArray());
}
return new COSInputStream(input, results);
}