You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/05/11 16:04:37 UTC

[GitHub] tajo pull request: TAJO-1598 TableMeta should change equals mechan...

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/565

    TAJO-1598 TableMeta should change equals mechanism

    In TableMeta equals, it compares Proto Data.
    but TableMetaProto has params as KeyValueSetProto. 
    It has a KeyValue Data as List.
    but it can cause comparison error. becuase list type compare items' order and value. but we should compare params like map.
    so this patch change compare machanism. compare storeType and Options

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/fix_option_creation_order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #565
    
----
commit 3a75ec45946ed2b5e3c1941405da313b379012a2
Author: clark.kang <cl...@kakao.com>
Date:   2015-05-10T14:48:19Z

    feature/fix_option_creation_order
    
    restore protected to private
    
    change TableMeta equals code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1598 TableMeta should change equals mechan...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/565


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---