You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2024/11/22 15:13:12 UTC
[PR] Add missing dependencies [maven-changes-plugin]
elharo opened a new pull request, #53:
URL: https://github.com/apache/maven-changes-plugin/pull/53
and remove an unused one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing dependencies [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #53:
URL: https://github.com/apache/maven-changes-plugin/pull/53#discussion_r1854218284
##########
pom.xml:
##########
@@ -292,6 +346,12 @@ under the License.
<version>4.11.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>1.3</version>
Review Comment:
there is a newer version ... as I remember
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing dependencies [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #53:
URL: https://github.com/apache/maven-changes-plugin/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing dependencies [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #53:
URL: https://github.com/apache/maven-changes-plugin/pull/53#discussion_r1854312390
##########
pom.xml:
##########
@@ -292,6 +346,12 @@ under the License.
<version>4.11.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>1.3</version>
Review Comment:
This is what we were getting. I'll look at upgrading dependencies in a separate PR if dependabot doesn't spot it first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org