You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/15 09:59:07 UTC
[GitHub] [incubator-eventmesh] liutaohua opened a new pull request #441: Fix typo for runtime package
liutaohua opened a new pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liutaohua commented on pull request #441: Fix typo for runtime package
Posted by GitBox <gi...@apache.org>.
liutaohua commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-880795972
Yes, I agree with you, but first of all, I don't study full-time, so I can only say to combine everything I learn every time.
Second, if you think the typo is irrelevant, I can close the pr and no longer submit the relevant content...
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liutaohua commented on pull request #441: [ISSUE #436] Fix typo errors
Posted by GitBox <gi...@apache.org>.
liutaohua commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-881155051
> @liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.
thanks Chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #441: Fix typo for runtime package
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-881104619
@liutaohua Understood, Thank You for your time, Any contributions are welcomed, but you can submit them one time As comlplete As You can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #441: Fix typo for runtime package
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-880608945
@liutaohua Can you fix all the typos in one PR? btw the title should follow the [ISSUE # ] format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen edited a comment on pull request #441: [ISSUE #436] Fix typo errors
Posted by GitBox <gi...@apache.org>.
qqeasonchen edited a comment on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-881154562
@liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #441: [ISSUE #436] Fix typo errors
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-881154562
@liutaohua I reopened the issue #441 and leave this pr pending so that you can add new commits here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #441: [ISSUE #436] Fix typo errors for runtime package
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #441: Fix typo for runtime package
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-880708195
@liutaohua Agree with @qqeasonchen, it may not be a problem in other scenarios, but currently, since many pr may change these file, frequent code change may cause others need to solve the conflict frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] liutaohua commented on pull request #441: [ISSUE #436] Fix typo errors for runtime package
Posted by GitBox <gi...@apache.org>.
liutaohua commented on pull request #441:
URL: https://github.com/apache/incubator-eventmesh/pull/441#issuecomment-881184015
> @liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.
I think the scope of the title is a bit too large. I'm not a spell checker, so I can't bear having to open every class once and fix all the typo.
I gave a preview of the basic logic of Runtime, and I thought that at least there were no obvious errors in Runtime, and that this PR could be incorporated.
If you think you need me to incorporate all the mistakes I found in the learning process into this PR, please keep it open for a long time. I will resolve the conflicts in an indefinite amount of time, or someone else will remember to fix them during development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org