[GitHub] [incubator-druid] suneet-amp commented on a change in pull request #8852: Refactor parallel indexing perfect rollup partitioning

[GitBox <gi...@apache.org>]

suneet-amp commented on a change in pull request #8852: Refactor parallel indexing perfect rollup partitioning
URL: https://github.com/apache/incubator-druid/pull/8852#discussion_r347510469
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/indexer/partitions/PartitionsSpec.java
 ##########
 @@ -75,4 +76,29 @@ static Integer resolveHistoricalNullIfNeeded(@Nullable Integer val)
   {
     return isEffectivelyNull(val) ? null : val;
   }
+
+  /**
+   * @return True if this partitionSpec's type is compatible with forceGuaranteedRollup=true.
+   */
+  @JsonIgnore
+  default boolean isForceGuaranteedRollupCompatibleType()
+  {
+    return !(this instanceof DynamicPartitionsSpec);
+  }
+
+  /**
+   * @return True if this partitionSpec's property values are compatible with forceGuaranteedRollup=true.
+   */
+  @JsonIgnore
+  default boolean isForceGuaranteedRollupCompatible()
+  {
+    return getForceGuaranteedRollupIncompatiblityReason().isEmpty();
+  }
+
+  /**
+   * @return Message describing why this partitionSpec is incompatible with forceGuaranteedRollup=true. Empty string if
+   * the partitionSpec is compatible.
+   */
+  @JsonIgnore
+  String getForceGuaranteedRollupIncompatiblityReason();
 
 Review comment:
   note to self: there are 3 ways of saying whether something is incompatible or not. Is there a better way to do this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org