You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "innerpeacez (via GitHub)" <gi...@apache.org> on 2023/03/29 08:54:00 UTC
[GitHub] [skywalking] innerpeacez opened a new pull request, #10610: Support alarm metric OP `!=`
innerpeacez opened a new pull request, #10610:
URL: https://github.com/apache/skywalking/pull/10610
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #10610: Support alarm metric OP `!=`
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #10610:
URL: https://github.com/apache/skywalking/pull/10610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] innerpeacez commented on pull request #10610: Support alarm metric OP `!=`
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488224665
> > > What is the use case of `not equal`?
> >
> >
> > labeled values metric. like node status
>
> Make sense. Please don't change the code style, I can't see it is relevant to this change.
I think using abbreviations for operator symbols is more elegant. I feel like the abbreviation and full name are mixed up(like LESS_EQ), and "<" should be translated as "less than".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10610: Support alarm metric OP `!=`
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488206768
What is the use case of `not equal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10610: Support alarm metric OP `!=`
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488212324
> > What is the use case of `not equal`?
>
> labeled values metric. like node status
Make sense. Please don't change the code style, I can't see it is relevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] innerpeacez commented on pull request #10610: Support alarm metric OP `!=`
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488209170
> What is the use case of `not equal`?
labeled values metric. like node status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10610: Support alarm metric OP `!=`
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488230890
> Dead Link Checker failing. I don't know why. doesn't seem to be related to this PR @wu-sheng
You don't have new link added. It is irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] innerpeacez commented on pull request #10610: Support alarm metric OP `!=`
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#issuecomment-1488229683
Dead Link Checker failing. I don't know why. doesn't seem to be related to this PR @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10610: Support alarm metric OP `!=`
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10610:
URL: https://github.com/apache/skywalking/pull/10610#discussion_r1151618409
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/OP.java:
##########
@@ -21,28 +21,28 @@
import static java.util.Objects.requireNonNull;
public enum OP {
- GREATER {
Review Comment:
Why do we need to change these? `NOT_EQUAL` seems also working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org