[GitHub] fabianmenges commented on a change in pull request #3521: Time Series Annotation Layers

[gi...@git.apache.org]

fabianmenges commented on a change in pull request #3521: Time Series Annotation Layers
URL: https://github.com/apache/incubator-superset/pull/3521#discussion_r141050236
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -57,6 +57,7 @@ def __init__(self, datasource, form_data):
             'token', 'token_' + uuid.uuid4().hex[:8])
         self.metrics = self.form_data.get('metrics') or []
         self.groupby = self.form_data.get('groupby') or []
+        self.annotation_layers = []
 
 Review comment:
   I don't think annotations should be part the viz object. For most viz types that I can think of annotations don't really make sense. If you make annotations accessible from a json endpoint they can be loaded client side. This would also make the responsiveness be better, annotations could be loaded async independently of the data.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services