Re: RES: Blank log messages when user has no access to specific folder

[Daniel Shahaf <d....@daniel.shahaf.name>]

The latter.  Though from memory it's a one-line change to
libsvn_repos/fs-wrap.c.

(no time right now or I'd give a better pointer)

Ricardo Smania (Desenv) wrote on Mon, May 16, 2011 at 13:33:20 -0300:
> Hello Daniel,
> 
> Is that patch already available or it would have to be developed from scratch?
> 
> Thank you,
> 
> Ricardo
> 
> 
> -----Mensagem original-----
> De: Daniel Shahaf [mailto:d.s@daniel.shahaf.name] 
> Enviada em: segunda-feira, 16 de maio de 2011 12:38
> Para: Ricardo Smania (Desenv)
> Cc: users@subversion.apache.org
> Assunto: Re: Blank log messages when user has no access to specific folder
> 
> Ricardo Smania (Desenv) wrote on Mon, May 16, 2011 at 11:10:34 -0300:
> > Is there a way to always show the log message, even if the user can't see the complete list of files/folders that were commited?
> > 
> 
> Not without applying a custom patch to the server.
> 
> (to libsvn_repos)

Re: RES: Blank log messages when user has no access to specific folder

[Daniel Shahaf <d....@daniel.shahaf.name>]

Daniel Shahaf wrote on Tue, May 17, 2011 at 09:56:56 +0200:
> The latter.  Though from memory it's a one-line change to
> libsvn_repos/fs-wrap.c.
> 

See svn_repos_fs_revision_prop()

> (no time right now or I'd give a better pointer)
> 
> Ricardo Smania (Desenv) wrote on Mon, May 16, 2011 at 13:33:20 -0300:
> > Hello Daniel,
> > 
> > Is that patch already available or it would have to be developed from scratch?
> > 
> > Thank you,
> > 
> > Ricardo
> > 
> > 
> > -----Mensagem original-----
> > De: Daniel Shahaf [mailto:d.s@daniel.shahaf.name] 
> > Enviada em: segunda-feira, 16 de maio de 2011 12:38
> > Para: Ricardo Smania (Desenv)
> > Cc: users@subversion.apache.org
> > Assunto: Re: Blank log messages when user has no access to specific folder
> > 
> > Ricardo Smania (Desenv) wrote on Mon, May 16, 2011 at 11:10:34 -0300:
> > > Is there a way to always show the log message, even if the user can't see the complete list of files/folders that were commited?
> > > 
> > 
> > Not without applying a custom patch to the server.
> > 
> > (to libsvn_repos)

Re: RES: Blank log messages when user has no access to specific folder

[Stefan Sperling <st...@elego.de>]

On Tue, May 17, 2011 at 09:56:56AM +0200, Daniel Shahaf wrote:
> The latter.  Though from memory it's a one-line change to
> libsvn_repos/fs-wrap.c.
> 
> (no time right now or I'd give a better pointer)

If such a patch was written we should probably add this as an option
specified somewhere in the authz grammar (allow_log or somesuch).

Though I like the pre-commit hook script suggestion by Thorsten as well.
It's definitely the quickest way to stop the problem from occurring ASAP.