You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/12 19:48:41 UTC

[GitHub] [nifi] turcsanyip commented on pull request #4330: NIFI-7527 AbstractKuduProcessor refresh TGT deadlock fix

turcsanyip commented on pull request #4330:
URL: https://github.com/apache/nifi/pull/4330#issuecomment-643455016


   `createKerberosUserAndKuduClient()` method seems to me obsolete now.
   
   Calling `createKuduClient()` from the method (line 144) is not necessary anymore because
   
   - `createKerberosUserAndKuduClient()` calls `createKerberosUser()`
   - which calls `loginKerberosKeytabUser()`
   - which creates a new `KerberosKeytabUser` and calls `login()` on it
   - and `login()` calls `createKuduClient()` (if not logged in, but it is the first login so definitely not)
   
   So I think `createKerberosUserAndKuduClient()` could be removed and `createKerberosUser()` could simply be called instead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org