You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 10:04:08 UTC

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16357: [fix][client-tool]fix the topic offload policy param will be covered unexpected.

Nicklee007 commented on code in PR #16357:
URL: https://github.com/apache/pulsar/pull/16357#discussion_r914658469


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java:
##########
@@ -1729,6 +1743,48 @@ void run() throws PulsarAdminException {
                 }
             }
 
+            int maxBlockSizeInBytes = OffloadPoliciesImpl.DEFAULT_MAX_BLOCK_SIZE_IN_BYTES;

Review Comment:
   The OffloadPoliciesImpl define the `managedLedgerOffloadMaxBlockSizeInBytes` and `managedLedgerOffloadReadBufferSizeInBytes` as Integer, as usual the block size or ReadBufferSize is less than GB, seems int is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org