You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:36:54 UTC

[GitHub] [mina-sshd] tomaswolf opened a new pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

tomaswolf opened a new pull request #204:
URL: https://github.com/apache/mina-sshd/pull/204


   Provide a default implementation for the server-side SSH_MSG_EXT_INFO
   message sending including the server-sig-algs KEX extension.[1]
   
   A server that implements the rsa-sha2-512 or rsa-sha2-256 signature
   algorithms should implement this extension, otherwise even clients that
   also have these signature algorithms may fall back to ssh-rsa to avoid
   authentication penalties.[2]
   
   Apache MINA sshd servers by default do implement the SHA-2 RSA
   signatures, and an Apache MINA sshd client by default does request KEX
   extension information and does handle the server-sig-algs extension. So
   an Apache MINA sshd server should by default implement this extension.
   
   This implementation sends the server-sig-algs extension record once at
   the end of the initial key exchange.
   
   [1] https://tools.ietf.org/html/rfc8308
   [2] https://tools.ietf.org/html/rfc8332#section-3.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

[GitHub] [mina-sshd] tomaswolf commented on pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

Posted by GitBox <gi...@apache.org>.
tomaswolf commented on pull request #204:
URL: https://github.com/apache/mina-sshd/pull/204#issuecomment-944997065


   Thanks for double-checking, @benhumphreys .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

[GitHub] [mina-sshd] benhumphreys commented on pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

Posted by GitBox <gi...@apache.org>.
benhumphreys commented on pull request #204:
URL: https://github.com/apache/mina-sshd/pull/204#issuecomment-944823080


   Many thanks for this @tomaswolf
   I've dropped a snapshot build of your branch into Bitbucket Server to do some testing and it looks great! I've tested with OpenSSH 8.1p1 and 8.8p1 and it works as expected, with both resulting in the use of `rsa-sha2-512`.
   
   I've also tested with OpenSSH 6.6.1p1 and it works as I'd expect; it doesn't send `server-sig-algs` because the client doesn't send `ext-info-s`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

[GitHub] [mina-sshd] tomaswolf merged pull request #204: [SSHD-1216] Server-side server-sig-algs KEX extension

Posted by GitBox <gi...@apache.org>.
tomaswolf merged pull request #204:
URL: https://github.com/apache/mina-sshd/pull/204


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org