You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/11 14:57:00 UTC
[jira] [Work logged] (MAPREDUCE-7379) RMContainerRequestor#makeRemoteRequest has confusing log message
[ https://issues.apache.org/jira/browse/MAPREDUCE-7379?focusedWorklogId=769122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769122 ]
ASF GitHub Bot logged work on MAPREDUCE-7379:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 14:56
Start Date: 11/May/22 14:56
Worklog Time Spent: 10m
Work Description: szilard-nemeth closed pull request #4282: YARN-9355. Fixed log message in RMContainerRequestor#makeRemoteRequest
URL: https://github.com/apache/hadoop/pull/4282
Issue Time Tracking
-------------------
Worklog Id: (was: 769122)
Time Spent: 1.5h (was: 1h 20m)
> RMContainerRequestor#makeRemoteRequest has confusing log message
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-7379
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7379
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Ashutosh Gupta
> Priority: Trivial
> Labels: newbie, newbie++, pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-9355.001.patch, YARN-9355.002.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest has this log:
> {code:java}
> if (ask.size() > 0 || release.size() > 0) {
> LOG.info("getResources() for " + applicationId + ":" + " ask="
> + ask.size() + " release= " + release.size() + " newContainers="
> + allocateResponse.getAllocatedContainers().size()
> + " finishedContainers=" + numCompletedContainers
> + " resourcelimit=" + availableResources + " knownNMs="
> + clusterNmCount);
> }
> {code}
> The reason why "getResources()" is printed because org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources invokes makeRemoteRequest. This is not too informative and error-prone as name of getResources could change over time and the log will be outdated. Moreover, it's not a good idea to print a method name from a method below the current one in the stack.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org