[GitHub] rnewson commented on a change in pull request #1789: New Feature: Database Partitions

[GitBox <gi...@apache.org>]

rnewson commented on a change in pull request #1789: New Feature: Database Partitions
URL: https://github.com/apache/couchdb/pull/1789#discussion_r242702739
 
 

 ##########
 File path: src/couch/src/couch_db.erl
 ##########
 @@ -583,6 +603,10 @@ get_db_info(Db) ->
         undefined -> null;
         Else1 -> Else1
     end,
+    Props = case couch_db_engine:get_props(Db) of
+        undefined -> null;
 
 Review comment:
   libraries, if they're sensible, should not be broken if new keys appear. Where we fall down sometimes is that libraries make assumptions about the types of the value (update_seq being an integer and then a string, but was json all along).
   
   imo, if we add a new key and a library breaks, then the library is at fault.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services