You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/06 10:12:52 UTC

[Bug 120832] New: Test for bug 120578: some of the font color is not correct

https://issues.apache.org/ooo/show_bug.cgi?id=120832

          Priority: P3
            Bug ID: 120832
          Assignee: ooo-issues@incubator.apache.org
           Summary: Test for bug 120578: some of the font color is not
                    correct
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: wujinlong@gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: AOO350-dev
         Component: code
           Product: word processor

Some of the font color is not correct in sample files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120832] Test for bug 120578: some of the font color is not correct

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120832

--- Comment #2 from bjcheny <co...@gmail.com> ---
Created attachment 79317
  --> https://issues.apache.org/ooo/attachment.cgi?id=79317&action=edit
Sample docx has text in table whose color is incorrect

Upload sample file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120832] Test for bug 120578: some of the font color is not correct

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120832

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79319|                            |review?
              Flags|                            |

--- Comment #3 from bjcheny <co...@gmail.com> ---
Created attachment 79319
  --> https://issues.apache.org/ooo/attachment.cgi?id=79319&action=edit
patch for font color in table

Both table style and color you set in table will affect last font color for
text in table. In this sample, the color set manually should have higher
priority than that from table style.

The patch involves:
1. In unotext.cxx::lcl_ApplyCellProperties(), when the char color fails to be
set on cell object, it will throw an exception. When the exception is caught,
we should check whether the char color is already existing or not, instead of
replacing it directly. Because if the color is already existing, it means color
comes from manually customization.
2. In DomainMapper.cxx, the table style's text properties will go to table's
properties in DomainMapperTableHandler::endTableGetTableStyle(). Thus, it
shouldn't  be merged here. Otherwise, it will be considered as those set
manually, and confuses logic mentioned above.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120832] Test for bug 120578: some of the font color is not correct

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120832

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |companycy@gmail.com

--- Comment #1 from bjcheny <co...@gmail.com> ---
I'm working on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120832] Test for bug 120578: some of the font color is not correct

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120832

zhang jianfang <zh...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zhangjf@apache.org
           Assignee|ooo-issues@incubator.apache |zhangjf@apache.org
                   |.org                        |
   Target Milestone|---                         |AOO 3.5.0

--- Comment #5 from zhang jianfang <zh...@apache.org> ---
take the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120832] Test for bug 120578: some of the font color is not correct

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120832

--- Comment #4 from bjcheny <co...@gmail.com> ---
Created attachment 79321
  --> https://issues.apache.org/ooo/attachment.cgi?id=79321&action=edit
UT docx has text in table

The sample's font color in table is decided by whole table type from table
style.

 w:type="table" w:styleId="MediumList1-Accent2">
<w:rPr>
    <w:color w:val="00FF00"/>
    <w:kern w:val="0"/>
    <w:sz w:val="22"/>
</w:rPr>

-- 
You are receiving this mail because:
You are the assignee for the bug.