You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/10 05:45:11 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29958: [SPARK-33079][TESTS] Replace the existing Maven job for Scala 2.13 in Github Actions with SBT job
dongjoon-hyun commented on a change in pull request #29958:
URL: https://github.com/apache/spark/pull/29958#discussion_r502750382
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -300,22 +300,18 @@ jobs:
steps:
- name: Checkout Spark repository
uses: actions/checkout@v2
- - name: Cache Maven local repository
+ - name: Cache Ivy local repository
uses: actions/cache@v2
with:
- path: ~/.m2/repository
- key: scala-213-maven-${{ hashFiles('**/pom.xml') }}
+ path: ~/.ivy2/cache
+ key: scala-213-ivy-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
- scala-213-maven-
+ scala-213-ivy-
- name: Install Java 11
uses: actions/setup-java@v1
with:
java-version: 11
- - name: Build with Maven
+ - name: Build with SBT
run: |
- export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
- export MAVEN_CLI_OPTS="--no-transfer-progress"
- mkdir -p ~/.m2
./dev/change-scala-version.sh 2.13
- ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Djava.version=11 -Pscala-2.13 install
- rm -rf ~/.m2/repository/org/apache/spark
+ ./build/sbt -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Djava.version=11 -Pscala-2.13 compile test:compile
Review comment:
So, we are going to remove `packaging` and `installation (Maven)` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org