Re: [PR] Interval tree for managing segment metadata in memory (druid)

["FrankChen021 (via GitHub)" <gi...@apache.org>]

FrankChen021 commented on code in PR #19138:
URL: https://github.com/apache/druid/pull/19138#discussion_r3173375286


##########
processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java:
##########
@@ -747,21 +795,38 @@ private List<TimelineObjectHolder<VersionType, ObjectType>> lookup(Interval inte
       timeline = completePartitionsTimeline;
     }
 
-    for (Entry<Interval, TimelineEntry> entry : timeline.entrySet()) {
-      Interval timelineInterval = entry.getKey();
-      TimelineEntry val = entry.getValue();
-
-      // exclude empty partition holders (i.e. tombstones) since they do not add value
-      // for higher level code...they have no data rows...
-      if ((!skipObjectsWithNoData || val.partitionHolder.hasData()) && timelineInterval.overlaps(interval)) {
-        retVal.add(
-            new TimelineObjectHolder<>(
-                timelineInterval,
-                val.getTrueInterval(),
-                val.getVersion(),
-                PartitionHolder.copyWithOnlyVisibleChunks(val.getPartitionHolder())
-            )
-        );
+    if (fastIntervalSearch) {

Review Comment:
   Thanks. Yes, that is the remaining concern: please run the existing VersionedIntervalTimeline coverage against fastIntervalSearch=true as well, since the IntervalTree tests don't exercise VIT's interval splitting/overshadowing behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org