You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/29 15:42:46 UTC

[GitHub] [incubator-dolphinscheduler] CalvinKirs edited a comment on pull request #4342: Master schedule service improve

CalvinKirs edited a comment on pull request #4342:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4342#issuecomment-752122636


   Deeply thanks for your contribution. But on this issue, we may need more discussion:
   
   I don’t think exit is a good solution (even if you use multiple intermittent retries). 
   
   I think the original design is better. I also have a reply in this issue #4226. 
   
   When the upstream is abnormal ( The downstream is strongly dependent on the upstream), our better approach is to adopt a circuit breaker strategy instead of directly downgrading.
   
   The original method (sleep is actually a means of circuit breakers)
   
   Maybe ,you can improve this, using the warning method here, or other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org