You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Dawid Weiss (JIRA)" <ji...@apache.org> on 2010/01/20 20:02:54 UTC
[jira] Created: (MAHOUT-264) Make mahout-math compatible with Java
1.5 (bytecode and standard library).
Make mahout-math compatible with Java 1.5 (bytecode and standard library).
--------------------------------------------------------------------------
Key: MAHOUT-264
URL: https://issues.apache.org/jira/browse/MAHOUT-264
Project: Mahout
Issue Type: Wish
Components: Math
Reporter: Dawid Weiss
Assignee: Benson Margulies
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-264) Make mahout-math compatible with Java
1.5 (bytecode and standard library).
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss updated MAHOUT-264:
-------------------------------
Attachment: MAHOUT-264.patch
As far a I can tell, this patch solves this issue. You still _must_ compile with a java 1.6 compiler (@Override annotations on interface methods), but the resulting bytecode is 1.5 compatible and does not use 1.6-specific API.
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-264) Make mahout-math compatible with Java
1.5 (bytecode and standard library).
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-264.
------------------------------
Resolution: Fixed
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Affects Versions: 0.2
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Fix For: 0.3
>
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-264) Make mahout-math compatible with
Java 1.5 (bytecode and standard library).
Posted by "Isabel Drost (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803281#action_12803281 ]
Isabel Drost commented on MAHOUT-264:
-------------------------------------
The changes to the pom look good.
But why are the changes to Sorting.java and Arrays.java needed?
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-264) Make mahout-math compatible with
Java 1.5 (bytecode and standard library).
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803346#action_12803346 ]
Dawid Weiss commented on MAHOUT-264:
------------------------------------
Because these methods in java.util.Arrays have been introduced as part of the Java 1.6 API and are not present on JRE 1.5. They are also intrinsic methods (replaced by HotSpot with efficient Java code); I believe the overhead of using System.arraycopy instead is minimal (I haven't verified this, but I believe Arrays intrinsics don't nullify the array space before copying, while the replacement does).
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (MAHOUT-264) Make mahout-math
compatible with Java 1.5 (bytecode and standard library).
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803346#action_12803346 ]
Dawid Weiss edited comment on MAHOUT-264 at 1/22/10 8:28 AM:
-------------------------------------------------------------
Because these methods in java.util.Arrays have been introduced as part of the Java 1.6 API and are not present on JRE 1.5. They are also intrinsic methods (replaced by HotSpot with efficient native code); I believe the overhead of using System.arraycopy instead is minimal (I haven't verified this, but I believe Arrays intrinsics don't nullify the array space before copying, while the replacement does).
was (Author: dawidweiss):
Because these methods in java.util.Arrays have been introduced as part of the Java 1.6 API and are not present on JRE 1.5. They are also intrinsic methods (replaced by HotSpot with efficient Java code); I believe the overhead of using System.arraycopy instead is minimal (I haven't verified this, but I believe Arrays intrinsics don't nullify the array space before copying, while the replacement does).
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Affects Versions: 0.2
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Fix For: 0.3
>
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-264) Make mahout-math compatible with Java
1.5 (bytecode and standard library).
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated MAHOUT-264:
-----------------------------
Affects Version/s: 0.2
Fix Version/s: 0.3
I like the idea of making this more reusable by requiring only 1.5. java.util.Arrays does exactly what the copy does, and both would get the same treatment by HotSpot. Shall I commit?
> Make mahout-math compatible with Java 1.5 (bytecode and standard library).
> --------------------------------------------------------------------------
>
> Key: MAHOUT-264
> URL: https://issues.apache.org/jira/browse/MAHOUT-264
> Project: Mahout
> Issue Type: Wish
> Components: Math
> Affects Versions: 0.2
> Reporter: Dawid Weiss
> Assignee: Benson Margulies
> Priority: Minor
> Fix For: 0.3
>
> Attachments: MAHOUT-264.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.