[GitHub] [incubator-druid] clintropolis opened a new pull request #7718: allow quantiles merge aggregator to also accept doubles

[GitBox <gi...@apache.org>]

clintropolis opened a new pull request #7718: allow quantiles merge aggregator to also accept doubles
URL: https://github.com/apache/incubator-druid/pull/7718
 
 
   Fixes #7660.
   
   This PR just does the quicker fix, modifying the merge aggregator to allow it to operate on either `DoubleSketch` selectors or `Double` selectors.
   
   The added test triggers a failure of the form:
   
   ```
   java.lang.ClassCastException: java.lang.Double cannot be cast to com.yahoo.sketches.quantiles.DoublesSketch
   ```
   
   without the modification of this patch.
   
   While investigating this issue, I have been reviewing many of the complex value aggregators, which are not incredibly consistent with each other in terms of usage/construction, but all have very similar needs: being able to build complex values, and being able to merge complex values. Refactoring to try to find a common pattern feels out of scope of fixing this issue though, so I will be hopefully revisiting this in a follow-up proposal or PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org