[GitHub] sdedic commented on a change in pull request #550: [NETBEANS-791] Highlights for the top line of JavaDoc are done on every line.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #550: [NETBEANS-791] Highlights for the top line of JavaDoc are done on every line.
URL: https://github.com/apache/incubator-netbeans/pull/550#discussion_r189550772
 
 

 ##########
 File path: javadoc/src/org/netbeans/modules/javadoc/highlighting/Highlighting.java
 ##########
 @@ -147,13 +154,34 @@ public void tokenHierarchyChanged(TokenHierarchyEvent evt) {
         if (seq.moveNext()) {
             int start = seq.offset();
             do {
+                String period = null;
+                int indexOfPeriod = -1;
+                for (String p : PERIODS) {
+                    int index = TokenUtilities.indexOf(seq.token().text(), p);
 
 Review comment:
   Wouldn't it be more appropriate if Javadoc lexer returned some specific tokenID japanese period char (and ordinary period char), since the period after the 1st sentence is a lexical element. But I fear that a new token ID could break existing lexer clients.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists