You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/06/27 19:09:25 UTC
[orc] branch main updated: ORC-821: Use mvnw instead of mvn (#725)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new 84bef37 ORC-821: Use mvnw instead of mvn (#725)
84bef37 is described below
commit 84bef37c44f2584a96b0f1e9777a2e7d5645e986
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Sun Jun 27 12:09:18 2021 -0700
ORC-821: Use mvnw instead of mvn (#725)
### What changes were proposed in this pull request?
This PR uses `mvnw` instead of `mvn` in our build system and documentation.
### Why are the changes needed?
For consistency.
### How was this patch tested?
Pass the CIs.
---
.github/workflows/publish_snapshot.yml | 2 +-
.travis.yml | 4 ++--
README.md | 4 +---
java/bench/README.md | 2 +-
site/_docs/building.md | 4 ++--
site/develop/make-release.md | 2 +-
6 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/.github/workflows/publish_snapshot.yml b/.github/workflows/publish_snapshot.yml
index 970f2e3..4b13542 100644
--- a/.github/workflows/publish_snapshot.yml
+++ b/.github/workflows/publish_snapshot.yml
@@ -23,4 +23,4 @@ jobs:
run: |
cd java
echo "<settings><servers><server><id>apache.snapshots.https</id><username>$ASF_USERNAME</username><password>$ASF_PASSWORD</password></server></servers></settings>" > settings.xml
- mvn --settings settings.xml -DskipTests deploy
+ ./mvnw --settings settings.xml -DskipTests deploy
diff --git a/.travis.yml b/.travis.yml
index e98ada4..5aff9a6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,8 +14,8 @@ matrix:
- MAVEN_OPTS=-Xmx2g MAVEN_SKIP_RC=true
script:
- cd java
- - mvn -Panalyze clean package
- - mvn apache-rat:check
+ - ./mvnw -Panalyze clean package
+ - ./mvnw apache-rat:check
- language: cpp
compiler: gcc
diff --git a/README.md b/README.md
index 326aff2..fd6c7dc 100644
--- a/README.md
+++ b/README.md
@@ -82,10 +82,8 @@ To build a release version without debug information:
To build only the Java library:
```shell
% cd java
-% mvn package
+% ./mvnw package
-# If you do not have a supported version of Maven installed locally
-% mvnw package
```
To build only the C++ library:
diff --git a/java/bench/README.md b/java/bench/README.md
index 0a85d44..45c65a0 100644
--- a/java/bench/README.md
+++ b/java/bench/README.md
@@ -15,7 +15,7 @@ There are three sub-modules to try to mitigate dependency hell:
To build this library:
-```% mvn clean package```
+```% ./mvnw clean package```
To fetch the source data:
diff --git a/site/_docs/building.md b/site/_docs/building.md
index 432966b..52af619 100644
--- a/site/_docs/building.md
+++ b/site/_docs/building.md
@@ -59,14 +59,14 @@ is invoking:
You'll need to install:
-* java (>= 1.7)
+* java (>= 1.8)
* maven (>= 3)
To build:
~~~ shell
% cd java
-% mvn package
+% ./mvnw package
~~~
## Building just C++
diff --git a/site/develop/make-release.md b/site/develop/make-release.md
index a7687e8..bc244ab 100644
--- a/site/develop/make-release.md
+++ b/site/develop/make-release.md
@@ -85,7 +85,7 @@ Publish the artifacts to Maven central staging. Make sure to have this [setup](h
~~~
% cd java
-% mvn -Papache-release clean deploy
+% ./mvnw -Papache-release clean deploy
~~~
Publish from the staging area: