You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/05/16 07:36:25 UTC
[Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
#529: Error dispatching web request to URL matching non-existing product
---------------------+---------------
Reporter: olemis | Owner:
Type: defect | Status: new
Priority: major | Version:
Resolution: |
---------------------+---------------
Details reported by TracStandalone
{{{#!py
Traceback (most recent call last):
File "/usr/lib/python2.6/SocketServer.py", line 558, in
process_request_thread
self.finish_request(request, client_address)
File "/usr/lib/python2.6/SocketServer.py", line 320, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python2.6/SocketServer.py", line 615, in __init__
self.handle()
File "/usr/lib/python2.6/BaseHTTPServer.py", line 329, in handle
self.handle_one_request()
File "/path/to/bloodhound/trac/trac/web/wsgi.py", line 191, in
handle_one_request
gateway.run(self.server.application)
File "/path/to/bloodhound/trac/trac/web/wsgi.py", line 91, in run
response = application(self.environ, self._start_response)
File "/path/to/bloodhound/trac/trac/web/standalone.py", line 91, in
__call__
return self.application(environ, start_response)
File "/path/to/bloodhound/trac/trac/web/main.py", line 439, in
dispatch_request
req = bootstrap.create_request(env, environ, start_response)
File "/path/to/bloodhound/trac/trac/hooks.py", line 220, in
create_request
return factory().create_request(env, environ, start_response) if
factory \
File
"/path/to/bloodhound/bloodhound_multiproduct/multiproduct/hooks.py", line
110, in create_request
return ProductRequestWithSession(env, environ, start_response)
File
"/path/to/bloodhound/bloodhound_multiproduct/multiproduct/hooks.py", line
102, in __init__
self.base_url = env.base_url
AttributeError: 'NoneType' object has no attribute 'base_url'
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#529: Error dispatching web request to URL matching non-existing product
------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: critical | Milestone: Release 6
Component: trac core | Version:
Resolution: | Keywords: hooks
------------------------+-----------------------
Changes (by rjollos):
* owner: => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#529: Error dispatching web request to URL matching non-existing product
------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: closed
Priority: critical | Milestone: Release 6
Component: trac core | Version:
Resolution: fixed | Keywords: hooks
------------------------+-----------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
A follow-on to [1488043] was discussed on the
[http://markmail.org/message/pk2a5jxflywelmuo mailing list], in which
Olemis suggested to //redirect to global products page and display a
custom message «Product %s not found».//
I'm closing this ticket and have opened #561 for [milestone:"Release 7"]
since further work against this ticket isn't critical for
[milestone:"Release 6"] and we don't yet have a patch.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Olemis Lang <ol...@gmail.com>.
On 5/30/13, Ryan Ollos <ry...@wandisco.com> wrote:
> On Thu, May 16, 2013 at 11:41 PM, Olemis Lang <ol...@gmail.com> wrote:
>
>> On 5/16/13, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
>> >
>> [...]
>> >
>> > [attachment:t529_r1482461_hooks_missing_product.diff Attached patch]
>> > solves this issue . Details
>> >
>>
>> Nevertheless IMO a better choice is to render :
>>
>> 1. an HTML error page
>> 2. products list with warning message on top
>>
>> What do you think ?
>>
>
> Either seem good to me. I agree that the behavior after the patch is
> better, but still not ideal.
>
Yes , I agree
> I studied the code for a short while, and it looks like you'd have to open
> the global environment and then raise a TracError. I'm sure you have a
> better understanding of this than I do.
>
I was thinking of redirecting to global products page and displaying a
custom message «Product %s not found» .
--
Regards,
Olemis.
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Ryan Ollos <ry...@wandisco.com>.
On Thu, May 16, 2013 at 11:41 PM, Olemis Lang <ol...@gmail.com> wrote:
> On 5/16/13, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
> >
> [...]
> >
> > [attachment:t529_r1482461_hooks_missing_product.diff Attached patch]
> > solves this issue . Details
> >
>
> Nevertheless IMO a better choice is to render :
>
> 1. an HTML error page
> 2. products list with warning message on top
>
> What do you think ?
>
Either seem good to me. I agree that the behavior after the patch is
better, but still not ideal.
I studied the code for a short while, and it looks like you'd have to open
the global environment and then raise a TracError. I'm sure you have a
better understanding of this than I do.
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Olemis Lang <ol...@gmail.com>.
On 5/16/13, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
>
[...]
>
> [attachment:t529_r1482461_hooks_missing_product.diff Attached patch]
> solves this issue . Details
>
Nevertheless IMO a better choice is to render :
1. an HTML error page
2. products list with warning message on top
What do you think ?
--
Regards,
Olemis.
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#529: Error dispatching web request to URL matching non-existing product
------------------------+-----------------------
Reporter: olemis | Owner:
Type: defect | Status: review
Priority: critical | Milestone: Release 6
Component: trac core | Version:
Resolution: | Keywords: hooks
------------------------+-----------------------
Changes (by olemis):
* owner: olemis =>
* status: accepted => review
Comment:
[attachment:t529_r1482461_hooks_missing_product.diff Attached patch]
solves this issue . Details
{{{
#!sh
$ hg qapplied
t529/t529_r1482461_hooks_missing_product.diff
$ hg log -r qparent --template="[{svnrev}] - {desc}\n"
[1482461] - also this (minor ticket scope creep to fix bhrelations for
testing) - #525
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#529: Error dispatching web request to URL matching non-existing product
------------------------+-----------------------
Reporter: olemis | Owner: olemis
Type: defect | Status: accepted
Priority: critical | Milestone: Release 6
Component: trac core | Version:
Resolution: | Keywords: hooks
------------------------+-----------------------
Changes (by olemis):
* status: new => accepted
* component: => trac core
* priority: major => critical
* owner: => olemis
* milestone: => Release 6
* keywords: => hooks
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #529: Error dispatching web request to URL
matching non-existing product
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#529: Error dispatching web request to URL matching non-existing product
------------------------+-----------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: critical | Milestone: Release 6
Component: trac core | Version:
Resolution: | Keywords: hooks
------------------------+-----------------------
Comment (by rjollos):
(In [1488043])
Refs #529: Allow an `HTTPInternalError` to be raised when the product
can't be found. Previously the request would not even return an error
page.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/529#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker