You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/04/01 07:31:23 UTC

[GitHub] [arrow-rs] viirya opened a new issue, #3995: Handle overflow precision when casting from integer to decimal

viirya opened a new issue, #3995:
URL: https://github.com/apache/arrow-rs/issues/3995

   **Describe the bug**
   <!--
   A clear and concise description of what the bug is.
   -->
   
   Although `cast` kernel uses `CastOptions` when casting from integer to decimal, its behavior on overflow-checking is incomplete.
   
   For now, it'd check division or multiplication if overflowing on underlying decimal native types (i.e., i128 and i256). But it doesn't check if input integer is overflowing on decimal precision. This causes weird behavior when downstream project (e.g., DataFusion) uses `cast` kernel to cast integer to decimal.
   
   
   **To Reproduce**
   <!--
   Steps to reproduce the behavior:
   -->
   
   **Expected behavior**
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #3995: Handle overflow precision when casting from integer to decimal

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3995:
URL: https://github.com/apache/arrow-rs/issues/3995#issuecomment-1500235877

   `label_issue.py` automatically added labels {'arrow'} from #3996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #3995: Handle overflow precision when casting from integer to decimal

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3995: Handle overflow precision when casting from integer to decimal
URL: https://github.com/apache/arrow-rs/issues/3995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org