You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/09/03 11:35:36 UTC

Re: [PR] fix(connectors): propagate sink plugin consume failure status [iggy]

hubcio commented on PR #3951:
URL: https://github.com/apache/iggy/pull/3951#issuecomment-5525100214

   closing in favour of #3954, which does the same status bind at `sink.rs:740` plus the offset-commit half you scoped out of here - so a rejected batch isn't just reported, it's redelivered.
   
   nothing wrong with this patch; #3950's repro is what got the runtime fix prioritized. flagged on #3954 that your process_messages unit tests should carry over - it only has integration coverage of that path.
   
   #3950 stays open until #3954 merges. thanks for the repro. @kriti-sc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org