You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/02/17 14:51:27 UTC
[jira] Created: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Warn operator when there is not enough disk space for compaction
----------------------------------------------------------------
Key: CASSANDRA-804
URL: https://issues.apache.org/jira/browse/CASSANDRA-804
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.6
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-804.
--------------------------------------
Resolution: Fixed
committed
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804-v3.txt, 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834781#action_12834781 ]
Jonathan Ellis commented on CASSANDRA-804:
------------------------------------------
the purpose is, if we can't compact all N files, see if we can compact N - 1, N - 2, etc. Merging rows will actually free space in the average case, so it's possible that by merging some files rather than giving up completely that we will actually succeed at all of them next time.
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-804:
-------------------------------------
Attachment: 804-v3.txt
combined patch attached
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804-v3.txt, 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834878#action_12834878 ]
Hudson commented on CASSANDRA-804:
----------------------------------
Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
use while loop instead of recursion when trimming sstables compaction list to avoid blowing stack in pathological cases.
patch by jbellis; reviewed by gdusbabe for
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804-v3.txt, 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834776#action_12834776 ]
Gary Dusbabek commented on CASSANDRA-804:
-----------------------------------------
I don't understand the purpose of the while loop. If there isn't enough space (compactionFileLocation==null), shouldn't the error be reported and the function return 0?
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834834#action_12834834 ]
Gary Dusbabek commented on CASSANDRA-804:
-----------------------------------------
+1
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804-v3.txt, 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-804:
-------------------------------------
Attachment: 804.txt
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-804:
-------------------------------------
Attachment: (was: 804.txt)
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834803#action_12834803 ]
Jonathan Ellis commented on CASSANDRA-804:
------------------------------------------
definitely, +1 your fix.
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-804:
-------------------------------------
Attachment: 804.txt
better patch.
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-804) Warn operator when there is not
enough disk space for compaction
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-804:
------------------------------------
Attachment: reset-compactionFileLocation.txt
That makes sense, but if I'm reading the code correctly, the loop will always empty out smallerSSTables since compactionFileLocation is invariant. Perhaps it should be reset in the while loop. (Apply reset-compactionFileLocation.txt on top of your patch to see.)
> Warn operator when there is not enough disk space for compaction
> ----------------------------------------------------------------
>
> Key: CASSANDRA-804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-804
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 804.txt, reset-compactionFileLocation.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.