You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/01 20:49:42 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
access2rohit opened a new pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267
## Description ##
earlier `split_and_save` on batch_axis=0 would take in CSRNDArray and return CSRNDArray but now its not doing the same and returns NDArray. This is change in behaviour.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702400958
@sxjscience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702469652
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702389591
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, edge, centos-cpu, centos-gpu, miscellaneous, website, windows-cpu, unix-cpu, windows-gpu, unix-gpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #19267: [v1.x] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19267: [v1.x] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702995932
@sxjscience can you review again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702403912
I think we may need to add a test case. Also, we should better add a comment in the code base that links to the issue. The root cause is that `slice_axis` has not supported sparse ndarray.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19267: [BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19267:
URL: https://github.com/apache/incubator-mxnet/pull/19267#issuecomment-702469684
Jenkins CI successfully triggered : [website, sanity, centos-gpu, centos-cpu, edge, windows-cpu, unix-cpu, clang, windows-gpu, miscellaneous, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org