You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/16 17:57:44 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 3.2.2
lordgamez opened a new pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963
Version 3.2.2 released single hpp library was downloaded from https://github.com/ThePhD/sol2/releases
------------------------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
Posted by GitBox <gi...@apache.org>.
lordgamez edited a comment on pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012
Summary of the issue from what I gathered:
- There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure, see 8.3 of the [Lua 5.4 reference](https://www.lua.org/manual/5.4/manual.html)
- Even though sol2 library bumped the valid Lua version to 5.4 in sol2 2.20.3 it was just [experimental ](https://github.com/ThePhD/sol2/issues/649)it does not guarantee compatibility.
- Lua 5.4 compatibility was introduced in sol2 v3.2.0, but sol2 v3.0+ versions make use of the c++17 and c++20 language feature and thus requires GCC 7.x.x and Clang 3.9.x compilers. Because of this we cannot upgrade to that version.
We need to revisit the upgrade after we reach the required compiler version. Until then I do not see any advantage of the version upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-746910434
Even though the compatibility error disappeared, the build still fails with the following:
```
2020-12-16T19:36:38.2089590Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5150:8: error: use of undeclared identifier 'LUA_ERRGCMM'
2020-12-16T19:36:38.2157510Z gc = LUA_ERRGCMM,
2020-12-16T19:36:38.2210480Z ^
2020-12-16T19:36:38.2292910Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5160:8: error: use of undeclared identifier 'LUA_ERRGCMM'
2020-12-16T19:36:38.2359110Z gc = LUA_ERRGCMM,
2020-12-16T19:36:38.2411820Z ^
2020-12-16T19:36:38.2496400Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5169:8: error: use of undeclared identifier 'LUA_ERRGCMM'
2020-12-16T19:36:38.2560740Z gc = LUA_ERRGCMM,
2020-12-16T19:36:38.2617600Z ^
2020-12-16T19:36:38.2706010Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5216:8: error: duplicate case value: 'gc' and 'file' both equal '6'
2020-12-16T19:36:38.2808040Z case call_status::file:
2020-12-16T19:36:38.2863160Z ^
2020-12-16T19:36:38.2922070Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5212:8: note: previous case defined here
2020-12-16T19:36:38.3010260Z case call_status::gc:
2020-12-16T19:36:38.3065550Z ^
2020-12-16T19:36:38.3125290Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5235:8: error: duplicate case value: 'gc' and 'file' both equal '6'
2020-12-16T19:36:38.3212600Z case call_status::file:
2020-12-16T19:36:38.3267340Z ^
2020-12-16T19:36:38.3328580Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5233:8: note: previous case defined here
2020-12-16T19:36:38.3414850Z case call_status::gc:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012
Summary of the issue from what I gathered:
- There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure see 8.3 of the [Lua 5.4 reference](https://www.lua.org/manual/5.4/manual.html)
- Even though sol2 library bumped the valid Lua version to 5.4 in sol2 2.20.3 it was just [experimental ](https://github.com/ThePhD/sol2/issues/649)it does not guarantee compatibility.
- Lua 5.4 compatibility was introduced in sol2 v3.2.0, but sol2 v3.0+ versions make use of the c++17 and c++20 language feature and thus requires GCC 7.x.x and Clang 3.9.x compilers. Because of this we cannot upgrade to that version.
We need to revisit the upgrade after we reach the required compiler version. Until then I do not see any advantage of the version upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org