You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/26 15:10:30 UTC
[GitHub] [doris] SWJTU-ZhangLei opened a new pull request, #10429: [Bugfix](fe) fix add follower failed, conflict socket .
SWJTU-ZhangLei opened a new pull request, #10429:
URL: https://github.com/apache/doris/pull/10429
# Proposed changes
Issue Number: close #10410
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] compiletheworld commented on pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
compiletheworld commented on PR #10429:
URL: https://github.com/apache/doris/pull/10429#issuecomment-1168178403
There are some checks that failed, please rebase or fix them first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #10429:
URL: https://github.com/apache/doris/pull/10429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] SWJTU-ZhangLei commented on a diff in pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
SWJTU-ZhangLei commented on code in PR #10429:
URL: https://github.com/apache/doris/pull/10429#discussion_r908121349
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2463,10 +2463,12 @@ public void addFrontend(FrontendNodeType role, String host, int editLogPort) thr
fe = new Frontend(role, nodeName, host, editLogPort);
frontends.put(nodeName, fe);
+ BDBHA bdbha = (BDBHA) haProtocol;
if (role == FrontendNodeType.FOLLOWER || role == FrontendNodeType.REPLICA) {
- ((BDBHA) getHaProtocol()).addHelperSocket(host, editLogPort);
+ bdbha.addHelperSocket(host, editLogPort);
Review Comment:
> Where does the conflict occur, and should we `removeConflictNodeIfExist` and then `addHelperSocket`?
help socket is used for self to connect with. firstly add help socket, secondly we can communicate with cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10429:
URL: https://github.com/apache/doris/pull/10429#issuecomment-1171883543
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] compiletheworld commented on a diff in pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
compiletheworld commented on code in PR #10429:
URL: https://github.com/apache/doris/pull/10429#discussion_r907995916
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2463,10 +2463,12 @@ public void addFrontend(FrontendNodeType role, String host, int editLogPort) thr
fe = new Frontend(role, nodeName, host, editLogPort);
frontends.put(nodeName, fe);
+ BDBHA bdbha = (BDBHA) haProtocol;
if (role == FrontendNodeType.FOLLOWER || role == FrontendNodeType.REPLICA) {
- ((BDBHA) getHaProtocol()).addHelperSocket(host, editLogPort);
+ bdbha.addHelperSocket(host, editLogPort);
Review Comment:
Where does the conflict occur, and should we `removeConflictNodeIfExist` and then `addHelperSocket`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] SWJTU-ZhangLei commented on a diff in pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
SWJTU-ZhangLei commented on code in PR #10429:
URL: https://github.com/apache/doris/pull/10429#discussion_r908130329
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2463,10 +2463,12 @@ public void addFrontend(FrontendNodeType role, String host, int editLogPort) thr
fe = new Frontend(role, nodeName, host, editLogPort);
frontends.put(nodeName, fe);
+ BDBHA bdbha = (BDBHA) haProtocol;
if (role == FrontendNodeType.FOLLOWER || role == FrontendNodeType.REPLICA) {
- ((BDBHA) getHaProtocol()).addHelperSocket(host, editLogPort);
+ bdbha.addHelperSocket(host, editLogPort);
Review Comment:
> Where does the conflict occur, and should we `removeConflictNodeIfExist` and then `addHelperSocket`?
https://docs.oracle.com/cd/E17277_02/html/java/com/sleepycat/je/rep/util/ReplicationGroupAdmin.html#getHelperSockets--
when new node start successfuly, others can get admin service from helper socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10429:
URL: https://github.com/apache/doris/pull/10429#issuecomment-1171883562
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org