You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/16 18:46:06 UTC

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #353: HDDS-2623. Expose SCMDatanodeProtocolServer RPC endpoint through Recon.

swagle commented on a change in pull request #353: HDDS-2623. Expose SCMDatanodeProtocolServer RPC endpoint through Recon.
URL: https://github.com/apache/hadoop-ozone/pull/353#discussion_r358401228
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
 ##########
 @@ -115,14 +115,15 @@
    */
   private final RPC.Server datanodeRpcServer;
 
-  private final StorageContainerManager scm;
+  private final StorageContainerManagerInterface scm;
 
 Review comment:
   It's uncanny to call something an interface, why not use IDE to refactor the StorageContainerManager into and interface? It would not be too big a change for callers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org