You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/04 23:12:53 UTC

[GitHub] [airflow] mik-laj commented on pull request #19181: More strict schema for values.yaml

mik-laj commented on pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#issuecomment-986107252


   I looked at the CI problem and I think the OpenAPI specification has a bug.
   
   ResourceQuotaSpec has the following definition:
   https://github.com/yannh/kubernetes-json-schema/blob/master/v1.21.0/resourcequotaspec.json
   ```json
   {
     "properties": {
       "hard": {
         "additionalProperties": {
           "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.21.0/_definitions.json#/definitions/io.k8s.apimachinery.pkg.api.resource.Quantity"
         },
         "type": [
           "object",
           "null"
         ]
       },
   ...
   ```
   and
   quantity has been defined as follow:
   https://github.com/yannh/kubernetes-json-schema/blob/master/v1.21.0/quantity.json
   ```json
   {
     "oneOf": [
       {
         "type": "string"
       },
       {
         "type": "number"
       }
     ],
     "$schema": "http://json-schema.org/schema#",
     "type": "object"
   }
   ```
   The fields `oneOf` and `type` are mutually exclusive. For now, I've copied the type definitions directly into the spec.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org