You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "vitaly-zdanevich (via GitHub)" <gi...@apache.org> on 2026/07/04 22:39:20 UTC
[PR] THRIFT-5955 Publish aarch64 Python wheels [thrift]
vitaly-zdanevich opened a new pull request, #3621:
URL: https://github.com/apache/thrift/pull/3621
## What changed
- Build the Python source distribution and manylinux aarch64 wheels in the PyPI release workflow.
- Run the release workflow on native GitHub-hosted arm64 runners.
- Fail cibuildwheel release builds when the fastbinary C extension cannot compile, avoiding accidental pure-Python wheel uploads.
## Why
THRIFT-5955 requests published manylinux aarch64 wheels for the Python package. The existing workflow only uploaded an sdist, so arm64 Linux users had to build from source.
## Validation
- Parsed `.github/workflows/pypi.yml` with Ruby YAML.
- Ran `python setup.py sdist --dist-dir /tmp/thrift-py-dist`.
- Ran `git diff --check`.
- Manually verified the cibuildwheel failure path with `CIBUILDWHEEL=1 CXX=false python setup.py build_ext --force`.
Jira: https://issues.apache.org/jira/browse/THRIFT-5955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5955 Require C extension in Python wheels [thrift]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #3621:
URL: https://github.com/apache/thrift/pull/3621#issuecomment-4888434670
This looks like the right behavior for release wheels: when `cibuildwheel` is producing binary artifacts for PyPI, silently falling back to a pure-Python wheel would make a broken fastbinary build easy to miss.
LGTM from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5955 Require C extension in Python wheels [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3621:
URL: https://github.com/apache/thrift/pull/3621#issuecomment-4897377294
> Not my cup of tea - asked Codex to do it.
I have also nothing to do with it. WTF ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5955 Require C extension in Python wheels [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3621:
URL: https://github.com/apache/thrift/pull/3621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org