You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 11:31:36 UTC
[GitHub] [incubator-tvm] kazum opened a new pull request #5219: [TOPI] Use
int32 for indices of strided_slice/take/gather_nd
kazum opened a new pull request #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219
When fusing concat op to strided_slice/take/gather_nd, we get a type mismatch error if the type of indices is int64.
@yzhliu @kevinthesun @yongwww, could you help review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kazum closed pull request #5219: [WIP] Support
int64 indices
Posted by GitBox <gi...@apache.org>.
kazum closed pull request #5219: [WIP] Support int64 indices
URL: https://github.com/apache/incubator-tvm/pull/5219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] hzfan edited a comment on issue #5219: [TOPI] Use
int32 for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
hzfan edited a comment on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-608979127
It seems like a workaround. It would be better if we can support i64 indices which does not fit into i32 (like 2^60). I made a little effort in #5235, but it is far from complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kazum commented on issue #5219: [TOPI] Use int32
for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
kazum commented on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-609674361
Okay, I'll give it a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] hzfan commented on issue #5219: [TOPI] Use int32
for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
hzfan commented on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-608979127
It would be great if we can support i64 indices which does not fit into i32 (like 2^60). Simply casting i64 to i32 does not work in this scenario. A possible alternative is to modify the `GetShape` function (https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/compile_engine.cc#L102) like #5235. Could you give it a try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5219: [TOPI] Use
int32 for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-609058346
I agree that supporting i64 indices(and i32 as well by auto promoting) is a better idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5219: [TOPI] Use int32
for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-608076076
also cc @hzfan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] hzfan edited a comment on issue #5219: [TOPI] Use
int32 for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
hzfan edited a comment on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-608979127
It seems like a workaround. It would be better if we can support i64 indices which does not fit into i32 (like 2^60).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] hzfan edited a comment on issue #5219: [TOPI] Use
int32 for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
hzfan edited a comment on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-608979127
It would be great if we can support i64 indices which does not fit into i32 (like 2^60). Simply casting i64 to i32 does not work in this scenario. A possible alternative is to modify the `GetShape` function (https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/compile_engine.cc#L102) like #5235 (just a demo, and far from complete). Could you give it a try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5219: [WIP] Support
int64 indices
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5219: [WIP] Support int64 indices
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-611836397
@kazum let us know if it is ready for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] kazum commented on issue #5219: [WIP] Support int64
indices
Posted by GitBox <gi...@apache.org>.
kazum commented on issue #5219: [WIP] Support int64 indices
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-612730071
@hzfan @tqchen Sorry, I'll withdraw this PR. Supporting i64 indices needs more changes than what I expected, and it would take much time for me to finish it. Rather than holding the PR for a long time, I'll close this PR for now so that other developers can have a chance to implement it instead.
@hzfan, if you'd send a PR for this, I'd be happy to review it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5219: [TOPI] Use int32
for indices of strided_slice/take/gather_nd
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5219: [TOPI] Use int32 for indices of strided_slice/take/gather_nd
URL: https://github.com/apache/incubator-tvm/pull/5219#issuecomment-609058346
I agree that supporting i64 indices is a better idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services