You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/09/30 06:58:12 UTC

[GitHub] [hbase] comnetwork edited a comment on pull request #3705: HBASE-26305 Move NavigableSet add operation to writer thread in BucketCache

comnetwork edited a comment on pull request #3705:
URL: https://github.com/apache/hbase/pull/3705#issuecomment-930871796


   @YutSean , for your PR,  I think one possible problem is if the ` BucketCache.evictBlocksByHfileName` is invoked after the `BucketCache.cacheBlock` but before the `WriterThread` to invoke `BucketCache.doDrain`, then this block could not be evicted right away, but I think this is not a big problem, because  :
   1.  This situation is rare.
   2. ` BucketCache.evictBlocksByHfileName`  and `BucketCache.cacheBlock` is not strictly synchronized in current code, so current code may also has this problem.
   3.  This block could be evicted eventually because no RPC referenced it.
   
   So I give +1 at this patch, @Apache9 , What is your opinion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org