You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/11/27 16:33:58 UTC

[jira] [Created] (BOOKKEEPER-485) TestFencing hung

Flavio Junqueira created BOOKKEEPER-485:
-------------------------------------------

             Summary: TestFencing hung
                 Key: BOOKKEEPER-485
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Flavio Junqueira


... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-485:
----------------------------------------

    Attachment: stack-trace-hung.txt
    
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506625#comment-13506625 ] 

Sijie Guo commented on BOOKKEEPER-485:
--------------------------------------

{quote}
+                    } else if (future.isSuccess() && state == ConnectionState.DISCONNECTED) {
+                        LOG.error("Closed before connection completed, clean up: " + addr);
+                        future.getChannel().close();
+                        rc = BKException.Code.BookieHandleNotAvailableException;
+                        channel = null;
+                        state = ConnectionState.DISCONNECTED;
{quote}

in this case, you assign the rc code to BookieHandleNotAvailableException. But it seems no so suitable, because actually the connect operation succeed and bookie is available. I think we need a better rc code here.

besides that, just be curious why you changed log level from DEBUG to INFO for connecting message.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504692#comment-13504692 ] 

Flavio Junqueira commented on BOOKKEEPER-485:
---------------------------------------------

It was a pretty long time. In fact, I forgot about it and came back several minutes later. It was there hung in that test. Now it is making progress just fine.

                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507378#comment-13507378 ] 

Ivan Kelly commented on BOOKKEEPER-485:
---------------------------------------

BookieHandleNotAvailableException is the closest to what has happened. The channel has been closed, so the bookie handle, is in fact not available. If clients need more details, they need to look at the logs. This isn't an error they should be able to recover from. If this occurs they need to fix their code.

It's useful to know which thread triggered the connect. The log on connection and disconnection are both INFO, so it made little sense to have this one as DEBUG, and it was annoying to have to enable debug logging just for this output.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506404#comment-13506404 ] 

Ivan Kelly commented on BOOKKEEPER-485:
---------------------------------------

Ok, so it's similar to BOOKKEEPER-5, but not the same. Basically, there's a race between closing the PerChannelBookieClient and the connection completing. If the PerChannelBookieClient requests to connect, and then is closed before the request completes, then the channel object returned on successful connection is orphaned. The fix is simple, im running in loop now. A succinct repo should be easy enough to implement as well. 
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507916#comment-13507916 ] 

Flavio Junqueira commented on BOOKKEEPER-485:
---------------------------------------------

+1, looks good, Ivan.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-485:
----------------------------------

    Attachment: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch

Addressed review comments.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506433#comment-13506433 ] 

Hadoop QA commented on BOOKKEEPER-485:
--------------------------------------

Testing JIRA BOOKKEEPER-485

WARNING: Running test-patch on a dirty local svn workspace

Patch <a href="/jira/secure/attachment/12555345/0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch">/jira/secure/attachment/12555345/0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch</a> downloaded at Thu Nov 29 12:01:14 UTC 2012

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
.    {color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
.    {color:red}WARNING: the current HEAD has  Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
.    Tests run: 384
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}.   There is at least one warning, please check{color}

The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/51/
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-485:
----------------------------------

    Attachment: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch

Fix is simple. Set the channel state to disconnected on close. If, on connection completion, the callback sees the state is in disconnected (rather than connecting), close the channel, and abort ops. The test case will successfully repro the issue if run without the fix, but the whole thing hangs due to releaseExternalResources being completely uninterruptible.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504678#comment-13504678 ] 

Flavio Junqueira commented on BOOKKEEPER-485:
---------------------------------------------

Attached stack trace.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504686#comment-13504686 ] 

Ivan Kelly commented on BOOKKEEPER-485:
---------------------------------------

TestFencing#testManyOpenParallel is a long running test sometimes. how long had it hung for. Situations like this is why we should get BOOKKEEPER-476 in soon.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-485:
----------------------------------------

    Priority: Critical  (was: Major)
    
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507420#comment-13507420 ] 

Flavio Junqueira commented on BOOKKEEPER-485:
---------------------------------------------

It looks good, just a couple of comments:

- I don't think this statement is needed: state = ConnectionState.DISCONNECTED;
- The test case is not really deterministic, although I understand that running it 1000 times will probably trigger it once. I can't come up with a good way of making it deterministic, though, so it is fine with me to have it like that. I just wanted to make the point and perhaps have a comment on the description of the test case for future reference.
- In ZooKeeper, we often have a {@link http://issues.apache.org/...} tag to link the test case to the jira issue. I like it, so I suggest we use it here too, but if you people don't like, we don't have to do it. Just a text reference as you have now is ok.
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508018#comment-13508018 ] 

Hudson commented on BOOKKEEPER-485:
-----------------------------------

Integrated in bookkeeper-trunk #833 (See [https://builds.apache.org/job/bookkeeper-trunk/833/])
    BOOKKEEPER-485: TestFencing hung (ivank via fpj)

--THIS line, and those below, will be ignored--

M    CHANGES.txt
A    bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java
M    bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java (Revision 1416000)

     Result = SUCCESS
fpj : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestPerChannelBookieClient.java

                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507589#comment-13507589 ] 

Hadoop QA commented on BOOKKEEPER-485:
--------------------------------------

Testing JIRA BOOKKEEPER-485

WARNING: Running test-patch on a dirty local svn workspace

Patch <a href="/jira/secure/attachment/12555548/0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch">/jira/secure/attachment/12555548/0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch</a> downloaded at Fri Nov 30 19:11:13 UTC 2012

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
.    {color:red}WARNING: the current HEAD has  Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
.    Tests run: 384
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}

{color:red}.   There is at least one warning, please check{color}

The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/57/
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Critical
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, 0001-BOOKKEEPER-485-Fix-race-between-PerChannelBookieClie.patch, stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-485) TestFencing hung

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504711#comment-13504711 ] 

Ivan Kelly commented on BOOKKEEPER-485:
---------------------------------------

Crap, looks like something BOOKKEEPER-5ish again. Look at "TestFencing-LedgerOpenThread-17".
                
> TestFencing hung
> ----------------
>
>                 Key: BOOKKEEPER-485
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-485
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Critical
>         Attachments: stack-trace-hung.txt
>
>
> ... while testing BOOKKEEPER-477, but I think they are unrelated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira