You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/10/22 02:34:34 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #2227: [CALCITE-4342] More aggregate functions should be marked as splittable and ignore distinct optionality

chunweilei commented on a change in pull request #2227:
URL: https://github.com/apache/calcite/pull/2227#discussion_r509843240



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java
##########
@@ -204,4 +204,11 @@ public boolean allowsFilter() {
   public boolean allowsNullTreatment() {
     return false;
   }
+
+  /**
+   * Get rollup aggregation function.
+   */
+  public SqlAggFunction getRollup() {

Review comment:
       Get -> Gets




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org