[jira] [Commented] (SOLR-15462) Dubious code in DistribPackageStore::refresh

["Joshua Ouma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615445#comment-17615445 ] 

Joshua Ouma commented on SOLR-15462:
------------------------------------

Hi [~cgrappa] Are you still  working on this?  I'd like to pick it up

> Dubious code in DistribPackageStore::refresh
> --------------------------------------------
>
>                 Key: SOLR-15462
>                 URL: https://issues.apache.org/jira/browse/SOLR-15462
>             Project: Solr
>          Issue Type: Task
>          Components: Package Manager
>            Reporter: Mike Drob
>            Priority: Major
>              Labels: newdev
>
> The code in DistribPackageStore::refresh is slightly dubious. Discovered while working on SOLR-15385...
> {code:java}
>     @SuppressWarnings({"rawtypes"})
>     List l = null;
>       l = coreContainer.getZkController().getZkClient().getChildren(ZK_PACKAGESTORE + path, null, true);
>       @SuppressWarnings({"rawtypes"})
>       List myFiles = list(path, s -> true);
>       for (Object f : l) {
>         // TODO: XXX DUBIOUS XXX
>         // l should be a List<String> and myFiles should be a List<FileDetails>, so contains should always return false!
>         if (!myFiles.contains(f)) {
> {code}
> This is concerning because if we have proper typing, then {{contains}} should always return false. Are we always downloading the files and improperly caching the results?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org