You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2015/09/04 00:13:46 UTC

[jira] [Commented] (PHOENIX-2207) Load scanner caches in parallel when using stats and round robin iterator

    [ https://issues.apache.org/jira/browse/PHOENIX-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729896#comment-14729896 ] 

James Taylor commented on PHOENIX-2207:
---------------------------------------

Thanks for the revisions, [~samarthjain]. Why not just have the Tuple use the iterator ID as the value? Then you'd need no static state or casting.
{code}
+    @Override
+    public Tuple next() throws SQLException {
+        iteratorOrder.add(id);
+        return dummyTuple; // create new Tuple each time with value of id
+    }
+
{code}

Too bad the TableResultIterator isn't created inside of the iteratorFactory.newIterator() method, as then I think we'd be able to do it. That might be a good change to make down the road, but having an IT test for now seems ok.

> Load scanner caches in parallel when using stats and round robin iterator
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-2207
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2207
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2207.patch, PHOENIX-2207_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)