You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Kinga Marton via Review Board <no...@reviews.apache.org> on 2018/06/27 18:47:47 UTC

Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67763/
-----------------------------------------------------------

Review request for oozie and András Piros.


Repository: oozie-git


Description
-------

Currently Findbugs complains about the a few warnings related to the reliance on the default encoding in the oozie-core module
They should be fixed to get the code more reliable.


Diffs
-----

  core/src/main/java/org/apache/oozie/StringBlob.java 6c776011 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d3 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 21c9b7e4 
  core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java d0b80742 
  core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 69d5e7e9 
  core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 128feee7 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 80e7d5d4 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 8bfa634f 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java 502a800f 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java 251838ce 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java c725f493 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0 
  core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22 
  core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f572 
  core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48 
  core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af 
  core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db3 
  core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b36 


Diff: https://reviews.apache.org/r/67763/diff/1/


Testing
-------


Thanks,

Kinga Marton


Re: Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67763/#review205625
-----------------------------------------------------------


Ship it!




Ship It!

- András Piros


On July 1, 2018, 10:47 a.m., Kinga Marton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67763/
> -----------------------------------------------------------
> 
> (Updated July 1, 2018, 10:47 a.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Currently Findbugs complains about the a few warnings related to the reliance on the default encoding in the oozie-core module
> They should be fixed to get the code more reliable.
> 
> 
> Diffs
> -----
> 
>   core/pom.xml a5a776ca6 
>   core/src/main/java/org/apache/oozie/StringBlob.java 6c776011c 
>   core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d35 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 21c9b7e4e 
>   core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java d0b807423 
>   core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 69d5e7e9b 
>   core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 128feee72 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 80e7d5d4b 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 8bfa634f8 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java 502a800fb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 251838ce7 
>   core/src/main/java/org/apache/oozie/service/WorkflowAppService.java c725f493e 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0d 
>   core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22f 
>   core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f5726 
>   core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48b 
>   core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af2 
>   core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db32 
>   core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b365 
> 
> 
> Diff: https://reviews.apache.org/r/67763/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>


Re: Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67763/
-----------------------------------------------------------

(Updated July 1, 2018, 10:47 a.m.)


Review request for oozie and András Piros.


Changes
-------

findbugs fix


Repository: oozie-git


Description
-------

Currently Findbugs complains about the a few warnings related to the reliance on the default encoding in the oozie-core module
They should be fixed to get the code more reliable.


Diffs (updated)
-----

  core/pom.xml a5a776ca6 
  core/src/main/java/org/apache/oozie/StringBlob.java 6c776011c 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d35 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 21c9b7e4e 
  core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java d0b807423 
  core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 69d5e7e9b 
  core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 128feee72 
  core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 80e7d5d4b 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 8bfa634f8 
  core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java 502a800fb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java 251838ce7 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java c725f493e 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0d 
  core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22f 
  core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f5726 
  core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48b 
  core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af2 
  core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db32 
  core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b365 


Diff: https://reviews.apache.org/r/67763/diff/2/

Changes: https://reviews.apache.org/r/67763/diff/1-2/


Testing
-------


Thanks,

Kinga Marton


Re: Review Request 67763: OOZIE-2956 Fix Findbugs warnings related to reliance on default encoding in oozie-core

Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67763/#review205502
-----------------------------------------------------------




core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
Line 122 (original), 125 (patched)
<https://reviews.apache.org/r/67763/#comment288409>

    Can you please mark these places with `@SuppressFBWarnings(value, justification)` just like [here](https://github.com/apache/oozie/blob/master/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1415-L1435)?



core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java
Line 525 (original), 522 (patched)
<https://reviews.apache.org/r/67763/#comment288410>

    Can you please mark these places with `@SuppressFBWarnings(value, justification)` just like [here](https://github.com/apache/oozie/blob/master/client/src/main/java/org/apache/oozie/cli/OozieCLI.java#L1415-L1435)?


- András Piros


On June 27, 2018, 6:47 p.m., Kinga Marton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67763/
> -----------------------------------------------------------
> 
> (Updated June 27, 2018, 6:47 p.m.)
> 
> 
> Review request for oozie and András Piros.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Currently Findbugs complains about the a few warnings related to the reliance on the default encoding in the oozie-core module
> They should be fixed to get the code more reliable.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/StringBlob.java 6c776011 
>   core/src/main/java/org/apache/oozie/action/ActionExecutor.java 919509d3 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherHelper.java 21c9b7e4 
>   core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java d0b80742 
>   core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 69d5e7e9 
>   core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 128feee7 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 80e7d5d4 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 8bfa634f 
>   core/src/main/java/org/apache/oozie/command/coord/CoordUpdateXCommand.java 502a800f 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 251838ce 
>   core/src/main/java/org/apache/oozie/service/WorkflowAppService.java c725f493 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 361141b0 
>   core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java 36a9de22 
>   core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 4fc8f572 
>   core/src/main/java/org/apache/oozie/util/IOUtils.java 3674dc48 
>   core/src/main/java/org/apache/oozie/util/MultiFileReader.java 1ab5a7af 
>   core/src/main/java/org/apache/oozie/util/XConfiguration.java e3591db3 
>   core/src/main/java/org/apache/oozie/util/XmlUtils.java 9db46b36 
> 
> 
> Diff: https://reviews.apache.org/r/67763/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kinga Marton
> 
>