You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "zhangfengcdt (via GitHub)" <gi...@apache.org> on 2024/07/17 17:23:12 UTC

[PR] Sedona 607 add safe geom [sedona]

zhangfengcdt opened a new pull request, #1525:
URL: https://github.com/apache/sedona/pull/1525

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-XXX. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   This PR make it feasible to return the geometry with the exception when ST functions fail and it will allow users to more quickly root cause exception and failures in their application.
   
   ## How was this patch tested?
   All unit tests and new unit tests on failed st function should throw expected error messages.
   
   ## Did this PR include necessary documentation updates?
   - Yes, I have updated the documentation. [TODO]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-607] Return geometry with ST functions with exceptions [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1525:
URL: https://github.com/apache/sedona/pull/1525


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-607] Return geometry with ST functions with exceptions [sedona]

Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on PR #1525:
URL: https://github.com/apache/sedona/pull/1525#issuecomment-2237847359

   > @Kontinuation @zhangfengcdt Can we also emit the values of non-spatial fields to provide more hints?
   
   I don't think it is possible given the current approach to solve this problem.
   
   Another concern is: sometimes the exceptions is not raised by ourselves, but somewhere inside JTS. This mostly happens in overlay functions (intersection, union, etc) and some topology-preserving transformation functions. We have to catch exceptions thrown by JTS and convert them to our own `IllegalGeometryException` exception, this is very tedious and certainly not what we want to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-607] Return geometry with ST functions with exceptions [sedona]

Posted by "zhangfengcdt (via GitHub)" <gi...@apache.org>.
zhangfengcdt commented on PR #1525:
URL: https://github.com/apache/sedona/pull/1525#issuecomment-2243473487

   > > @Kontinuation @zhangfengcdt Can we also emit the values of non-spatial fields to provide more hints?
   > 
   > I don't think it is possible given the current approach to solve this problem.
   > 
   > Another concern is: sometimes the exceptions is not raised by ourselves, but somewhere inside JTS. This mostly happens in overlay functions (intersection, union, etc) and some topology-preserving transformation functions. We have to catch exceptions thrown by JTS and convert them to our own `IllegalGeometryException` exception, this is very tedious and certainly not what we want to do.
   
   Thanks, @Kontinuation @jiayuasu for the suggestions. I have refactor the code to add the input row string to the exceptions. Also, in case input is null (e.g., rows are created in test using SQL literals), I add the literals to the exception. This will help with the debug cases as well. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org