You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/07 05:36:41 UTC

[GitHub] [incubator-mxnet] samskalicky edited a comment on pull request #18779: [WIP] Support extra inputs for subgraph ops

samskalicky edited a comment on pull request #18779:
URL: https://github.com/apache/incubator-mxnet/pull/18779#issuecomment-670334981


   > > @eric-haibin-lin @MoisesHer what do you think about changing the graph pass API from taking a String (symbol JSON) to a Graph object like:
   >
   > From a user perspective (someone defining a pass) I think a graph is preferred. I guess the user will not have to re-implement class Graph  anymore, and will skip conversion from String <-> graph
   
   Can you review again? updated Graph to embed the args/aux as tensors within the appropriate Node's. And made it so that you can just call `node->alloc_arg/aux()` to allocate a tensor for a node in the graph. Per our offline discussion this simplifies graph passes significantly. 
   
   https://github.com/apache/incubator-mxnet/pull/18779/files#diff-6620d12b32554c7f5ae8a6d1b789aea3R324-R332


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org