You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/19 10:54:02 UTC
[jira] [Commented] (FLINK-8697) Rename DummyFlinkKafkaConsumer in
Kinesis tests
[ https://issues.apache.org/jira/browse/FLINK-8697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368984#comment-16368984 ]
ASF GitHub Bot commented on FLINK-8697:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/commit/30677772e29a8bbb667d098c43a0b225d5602049#commitcomment-27650676
In flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcherTest.java:
In flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcherTest.java on line 113:
yes it's a typo. I've filed a [JIRA](https://issues.apache.org/jira/browse/FLINK-8697).
> Rename DummyFlinkKafkaConsumer in Kinesis tests
> -----------------------------------------------
>
> Key: FLINK-8697
> URL: https://issues.apache.org/jira/browse/FLINK-8697
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector, Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Priority: Trivial
> Fix For: 1.5.0
>
>
> In {{KinesisDataFetcherTest}} exists a class
> {code}
> private static class DummyFlinkKafkaConsumer<T> extends FlinkKinesisConsumer<T> {
> {code}
> The class should be called {{DummyFlinkKinesisConsumer}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)