[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7570: Optimize data consistency checker.

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #7570:
URL: https://github.com/apache/shardingsphere/pull/7570#discussion_r493722838



##########
File path: shardingsphere-scaling/shardingsphere-scaling-bootstrap/src/main/java/org/apache/shardingsphere/scaling/web/HttpServerHandler.java
##########
@@ -122,8 +124,8 @@ private void stopJob(final ChannelHandlerContext context, final String requestBo
     private void checkJob(final ChannelHandlerContext context, final String requestPath) {
         int jobId = Integer.parseInt(requestPath.split("/")[4]);
         try {
-            boolean success = SCALING_JOB_CONTROLLER.check(jobId);
-            response(GSON.toJson(ResponseContentUtil.build(success)), context, HttpResponseStatus.OK);
+            Map<String, DataConsistencyCheckResult> result = SCALING_JOB_CONTROLLER.check(jobId);

Review comment:
       Please do not name `result` if the method is void

##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/datasource/DataSourceWrapper.java
##########
@@ -17,11 +17,89 @@
 
 package org.apache.shardingsphere.scaling.core.datasource;
 
+import lombok.AllArgsConstructor;
+
 import javax.sql.DataSource;
 import java.io.Closeable;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
+import java.util.logging.Logger;
 
 /**
  * Data source wrapper is for abstract standard jdbc and sharding jdbc.
  */
-public interface DataSourceWrapper extends DataSource, Closeable {
+@AllArgsConstructor

Review comment:
       Can use RequiredArgsConstructor here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org