[GitHub] wu-sheng commented on a change in pull request #1913: fix bug #1912, the usage of ignore() problem

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1913: fix bug #1912, the usage of ignore() problem
URL: https://github.com/apache/incubator-skywalking/pull/1913#discussion_r234111872
 
 

 ##########
 File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
 ##########
 @@ -75,12 +76,14 @@ public static void premain(String agentArgs, Instrumentation instrumentation) th
 
         new AgentBuilder.Default(byteBuddy)
             .ignore(nameStartsWith("net.bytebuddy."))
-            .ignore(nameStartsWith("org.slf4j."))
-            .ignore(nameStartsWith("org.apache.logging."))
-            .ignore(nameStartsWith("org.groovy."))
-            .ignore(nameContains("javassist"))
-            .ignore(nameContains(".asm."))
-            .ignore(allSkyWalkingAgentExcludeToolkit())
+                .or(nameStartsWith("org.slf4j."))
+                .or(nameStartsWith("org.apache.logging."))
+                .or(nameStartsWith("org.groovy."))
+                .or(nameContains("javassist"))
+                .or(nameContains(".asm."))
+                .or(nameStartsWith("sun.reflect"))
+                .or(allSkyWalkingAgentExcludeToolkit()
+                .or(ElementMatchers.<TypeDescription>isSynthetic()))
 
 Review comment:
   Why need this? I thought `isSynthetic` should be field modifier? Which class definition is with this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services