You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jordan Zimmerman (JIRA)" <ji...@apache.org> on 2009/02/24 02:40:01 UTC
[jira] Created: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
--------------------------------------------------------------------------------------------------
Key: SHINDIG-936
URL: https://issues.apache.org/jira/browse/SHINDIG-936
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: trunk
Reporter: Jordan Zimmerman
PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676345#action_12676345 ]
Adam Winer commented on SHINDIG-936:
------------------------------------
executeSocialRequest() is in the latest code on trunk:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java
Recommend overriding that instead of binding a custom pipeline.
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676187#action_12676187 ]
Adam Winer commented on SHINDIG-936:
------------------------------------
One question: you can set a different url via the config, including query params. You could also override executeSocialRequest() and programmatically add params. This isn't sufficient?
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman updated SHINDIG-936:
-------------------------------------
Attachment: fix-936-bug.patch
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676489#action_12676489 ]
Jordan Zimmerman commented on SHINDIG-936:
------------------------------------------
I just took a look at the latest PipelinedDataPreloader. The way that DefaultGuiceModule is written, overriding executeSocialRequest isn't possible. I'll open a separate task on this.
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676197#action_12676197 ]
Jordan Zimmerman commented on SHINDIG-936:
------------------------------------------
* I can't do it in the config because I need to add arguments generated at runtime.
* Where is executeSocialRequest()? I grep'd the source and can't find it.
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-936) Make
PipelinedDataPreloader.getSocialUri() protected so that
PipelinedDataPreloader can be re-used
Posted by "Jordan Zimmerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan Zimmerman resolved SHINDIG-936.
--------------------------------------
Resolution: Invalid
The workaround suggested by Winer above works:
bind RequestPipeline to a custom implementation that extends DefaultRequestPipeline. You can then override execute(HttpRequest)
> Make PipelinedDataPreloader.getSocialUri() protected so that PipelinedDataPreloader can be re-used
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-936
> URL: https://issues.apache.org/jira/browse/SHINDIG-936
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-936-bug.patch
>
>
> PipelinedDataPreloader.getSocialUri() is private. I'd like to use the behavior of PipelinedDataPreloader but change slightly how getSocialUri() works. I need additional parameters in the URL. So, make getSocialUri() protected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.