You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/02 16:42:26 UTC

[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #2016: a little modification, this is a start...

KevinClair commented on a change in pull request #2016:
URL: https://github.com/apache/incubator-shenyu/pull/2016#discussion_r701250907



##########
File path: shenyu-admin/src/test/java/org/apache/shenyu/admin/AbstractReflectGetterSetterTest.java
##########
@@ -87,7 +86,7 @@
     protected abstract Class<?> getTargetClass();
 
     protected Set<String> getExcludeFields() {
-        return new HashSet<>(Arrays.asList("serialVersionUID"));
+        return new HashSet<>(Collections.singletonList("serialVersionUID"));

Review comment:
       Why modify this place, `java.util.Arrays.ArrayList` and `java.util.Collections.SingletonList` have the same parent class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org