You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/20 07:17:56 UTC

[GitHub] [flink] zjuwangg commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable…

zjuwangg commented on a change in pull request #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable…
URL: https://github.com/apache/flink/pull/9721#discussion_r326499654
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
 ##########
 @@ -80,23 +83,27 @@ public HiveTableSource(JobConf jobConf, ObjectPath tablePath, CatalogTable catal
 	private HiveTableSource(JobConf jobConf, ObjectPath tablePath, CatalogTable catalogTable,
 
 Review comment:
   Maybe it's better to add some method comments here to indicate its effect on projection or partition-prunning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services