[GitHub] [accumulo] cshannon commented on pull request #3064: Update formatting to match google style guide

[GitBox <gi...@apache.org>]

cshannon commented on PR #3064:
URL: https://github.com/apache/accumulo/pull/3064#issuecomment-1303612907

   My thinking was that we'd either want to do it at the beginning (now) or we might end up waiting until the end based on the comments @ctubbsii made about waiting until the last minute to do the refactor of the fate packages for 2.1.0. Waiting until the end certainly makes merging between branches easier but 2.1 is a long term release anyways so it would still be a problem in the future even after 3.0. Either way, I at least wanted to get some feedback on the new style as I generally think the Google style is one of the better ones.
   
   Trying to give info or warnings for the new style but not enforcing it yet to avoid breaking existing code is an interesting idea but I'm not sure if we could do that without a million warnings spitting out for all the existing code during the build process as there's a lot that needs to be reformatted. There was a surprising number of places with missing curly braces for example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org