[jira] [Commented] (NIFI-5727) Optimize GenerateTableFetch to remove unnecessary COUNT(*)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656677#comment-16656677 ] 

ASF GitHub Bot commented on NIFI-5727:
--------------------------------------

GitHub user rednikotin opened a pull request:

    https://github.com/apache/nifi/pull/3094

    NIFI-5727 - Optimize GenerateTableFetch to remove unnecessary COUNT(*)

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rednikotin/nifi NIFI-5727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3094
    
----
commit 62b061e91b7e8475603a4bcd1e4d06636824ef1f
Author: rednikotin <ni...@...>
Date:   2018-10-19T11:22:33Z

    Added replace unnecessary row count with -1 stub value when paging is used

----


> Optimize GenerateTableFetch to remove unnecessary COUNT(*)
> ----------------------------------------------------------
>
>                 Key: NIFI-5727
>                 URL: https://issues.apache.org/jira/browse/NIFI-5727
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.7.1
>            Reporter: Valentin Nikotin
>            Priority: Minor
>
> When processor is configured to use *"Column for Value Partitioning"* processor property it still [calculates|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java#L293] {{COUNT(*)}} while it's not used further in code.
> At line 292 code adds an explicit {{SELECT COUNT(*)}} to the query that calculates the bounds of the partitions:
> {code:java}
>             List<String> maxValueSelectColumns = new ArrayList<>(numMaxValueColumns + 1);
>             maxValueSelectColumns.add("COUNT(*)");
> {code}
> At [line 414|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java#L414] we see that the count is only used if no columns have been set for paging:
> {code:java}
>                 if (useColumnValsForPaging) {
>                     final long valueRangeSize = maxValueForPartitioning == null ? 0 : (maxValueForPartitioning - minValueForPartitioning + 1);
>                     numberOfFetches = (partitionSize == 0) ? 1 : (valueRangeSize / partitionSize) + (valueRangeSize % partitionSize == 0 ? 0 : 1);
>                 } else {
>                     numberOfFetches = (partitionSize == 0) ? 1 : (rowCount / partitionSize) + (rowCount % partitionSize == 0 ? 0 : 1);
>                 }
> {code}
> Since the {{SELECT COUNT(*)}} sometimes takes too long to complete, we want to optimize this code and perform the {{SELECT COUNT(*)}} only when property *"Column for Value Partitioning"* has not been set.
> The idea is to use *-1* value to minimize code changes:
> {code:java}
>             if (useColumnValsForPaging) {
>                 maxValueSelectColumns.add("-1");
>             } else {
>                 maxValueSelectColumns.add("COUNT(*)");
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)